Skip to content

Handle join_keys_to_values() with undef values.#874

Merged
hunner merged 1 commit intopuppetlabs:masterfrom
BobVanB:UPDATE-join_keys_to_values
Jan 23, 2018
Merged

Handle join_keys_to_values() with undef values.#874
hunner merged 1 commit intopuppetlabs:masterfrom
BobVanB:UPDATE-join_keys_to_values

Conversation

@BobVanB
Copy link
Copy Markdown
Contributor

@BobVanB BobVanB commented Jan 22, 2018

support flags

gitlab_ci_runners_defaults:
  tag-list: 'custom'
  run-untagged:
  executor: 'shell'

(gitlab module joins on space)
would become:
--tag-list custom --run-untagged --executor shell

the --run-untagged does not accept values.

Because puppet and hieradata returns string values i had to use String(v) == "undef".
I couldn't get it to work with not defined?(v) or v.nil?.

@hunner hunner changed the title Update join_keys_to_values with an undef statement. Handle join_keys_to_values() with undef values. Jan 23, 2018
@hunner hunner added the bugfix label Jan 23, 2018
@hunner hunner merged commit 1dd3b92 into puppetlabs:master Jan 23, 2018
hunner added a commit that referenced this pull request Jan 23, 2018
Handle join_keys_to_values() with undef values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants